Lodash: Deprecate _.set()
#52407
Merged
Lodash: Deprecate _.set()
#52407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 82130f3d3b36d72cac64262e5991ae73ed8b6126. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5484390783
|
tyxla
force-pushed
the
deprecate/lodash-set
branch
from
82130f3
to
c043609
Compare
tyxla
force-pushed
the
deprecate/lodash-set
branch
from
c043609
to
35b0839
Compare
tyxla
removed
the
[Status] Blocked
ntsekouras
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR deprecates Lodash's
_.set()function.Was blocked by:
_.set()ingetNodesWithSettings()#52278_.set()in global styles #52279_.set()inPushChangesToGlobalStylesControl#52404Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're adding
_.set()to the list of deprecated Lodash functions in our ESLint configuration.Testing Instructions
Not needed.